refactor(install): split pipeline modules#702
Conversation
Greptile SummaryPure mechanical split of
Confidence Score: 5/5Safe to merge — this is a purely mechanical code move with no logic changes. Every function, type, constant, and test block is moved verbatim from mod.rs into the new sibling files. The only changes are visibility upgrades (private to pub(super)) required to let mod.rs import the moved items, and those upgrades are all scoped to within the install module boundary. Module wiring in mod.rs is minimal and correct. No callers outside install are affected. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "refactor(install): split pipeline module..." | Re-trigger Greptile |
What changed
commands/install/materialize.rs.commands/install/critical_path.rs.commands/install/workspace.rs.Why
This follows PR #698 with a larger mechanical refactor.
commands/install/mod.rsstill owned several unrelated install subdomains after the first helper split; moving these chunks gives materialization, workspace handling, and critical-path ordering narrower homes while preserving the existing install flow.Validation
cargo fmt --checkcargo check -p aubecargo clippy -p aube --all-targets -- -D warningscargo test -p aube commands::installNote
Low Risk
Mostly a mechanical refactor that moves install helper logic (materialization, workspace helpers, native-build heuristic) into new modules, with minimal behavioral change expected. Risk is limited to potential wiring/visibility mistakes during the move affecting install flow or error reporting.
Overview
Refactors
installby extracting three previously inlined chunks fromcommands/install/mod.rsinto dedicated modules:materialize.rs(materializer channel/task + error-combining helper),critical_path.rs(native-build heuristic used for fetch reordering), andworkspace.rs(workspace graph filtering, lifecycle manifest ordering, and per-project lockfile writing helpers).Updates
install/mod.rsto import these helpers from the new modules and relocates the associated unit tests alongside each module.Reviewed by Cursor Bugbot for commit d968f6a. Bugbot is set up for automated code reviews on this repo. Configure here.