feat(run): forward inspect flags to node targets#515
Conversation
Greptile Summary
Confidence Score: 5/5Safe to merge — no P0 or P1 issues; the one finding is a minor silent no-op in an edge case. All findings are P2. The shebang-check and file-read concerns from the previous review round are resolved. The core flag-forwarding logic, shim parsing, and injection guards are sound. crates/aube/src/commands/exec.rs — parse_posix_node_path multi-entry NODE_PATH edge case. Important Files Changed
Reviews (5): Last reviewed commit: "fix(run): preserve bin shim env for insp..." | Re-trigger Greptile |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4765106. Configure here.

Summary
aube run --inspect[=port]and--inspect-brk[=port].node ...scripts and local Node-backed.binfallbacks.NODE_OPTIONS, so debugger flags do not leak into every nested Node process.Context
This addresses feedback from Discussion #345 asking for
aube run --inspect test/--inspect-brksupport. Yarn supports this shape for Node-backed binaries; npm and pnpm do not appear to forward these flags forrun, so aube keeps the behavior narrowly scoped to commands it can identify as Node-backed.Validation
cargo test -p aube commands::run::testscargo test -p aube commands::exec::testsmise run test:bats test/run.batscargo fmt --checkcargo clippy -p aube --all-targets -- -D warningsNote
Medium Risk
Changes how
aube runconstructs and executes commands (including.binfallback resolution), which could affect script/binary invocation across platforms. Scope is constrained to detected Node-backed targets and covered by new unit/Bats tests.Overview
aube runnow accepts--inspect[=[[HOST:]PORT]]and--inspect-brk[=[[HOST:]PORT]]and forwards them as explicit Node argv when running directnode ...package.json scripts or when falling back to local Node-backednode_modules/.binbinaries.This refactors execution helpers to thread
node_argsthrough script/bin execution, adds cross-platform logic inexecto resolve.binshims/symlinks and detect Node interpreters before injecting args, and updates CLI docs plus Bats/unit test coverage for the new behavior.Reviewed by Cursor Bugbot for commit 9498953. Bugbot is set up for automated code reviews on this repo. Configure here.