Skip to content

ci: bump release upload-assets timeout to 60 minutes#463

Merged
jdx merged 1 commit intomainfrom
bump-windows-release-timeout
May 1, 2026
Merged

ci: bump release upload-assets timeout to 60 minutes#463
jdx merged 1 commit intomainfrom
bump-windows-release-timeout

Conversation

@jdx
Copy link
Copy Markdown
Contributor

@jdx jdx commented May 1, 2026

Summary

Windows release builds consistently land 25-28 min against the 30-min cap (v1.6.0: 25m43s / 27m11s; v1.6.1 just timed out at 30m on aarch64-pc-windows-msvc). Bump every upload-assets target to 60 min so runner variance doesn't tip releases over.

Test plan

  • Re-run release.yml for v1.6.1 with tag: v1.6.1 after merge → confirm Windows tarballs land

🤖 Generated with Claude Code


Note

Low Risk
Low risk: CI-only change that just allows more time for release build/upload jobs; no product code or security logic is modified.

Overview
Increases the GitHub Actions release.yml upload-assets job timeout from 30 to 60 minutes to reduce release failures from long/variable build times (notably on Windows).

Reviewed by Cursor Bugbot for commit daf6cbd. Bugbot is set up for automated code reviews on this repo. Configure here.

Windows builds (cargo, no LLD) consistently land 25-28 minutes
against the previous 30-minute cap, leaving no headroom for runner
variance. Bump all targets to 60 min for a uniform, comfortable
ceiling.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 1, 2026

Greptile Summary

This PR increases the timeout-minutes for the upload-assets job in release.yml from 30 to 60 minutes. The change is directly motivated by observed Windows build durations (25–28 min) that leave little margin against the previous 30-minute cap, with aarch64-pc-windows-msvc already timing out in v1.6.1.

Confidence Score: 5/5

Safe to merge — single-line CI config change with clear empirical justification and no functional risk.

No logic, security, or correctness issues. The new 60-minute limit is a sensible upper bound that still protects against truly stuck jobs while giving Windows runners adequate headroom.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/release.yml Bumps timeout-minutes for the upload-assets job from 30 to 60 to accommodate Windows build variance; change is minimal, well-justified, and correct.

Reviews (1): Last reviewed commit: "ci: bump release upload-assets timeout t..." | Re-trigger Greptile

@jdx jdx merged commit 3ed617b into main May 1, 2026
19 checks passed
@jdx jdx deleted the bump-windows-release-timeout branch May 1, 2026 21:23
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

Benchmark changes

Versions:

  • aube: 1.5.2 -> 1.6.1

Public ratios: warm installs vs Bun 6x -> 8x; warm installs vs pnpm 10x -> 13x.

Benchmark aube bun pnpm
Fresh install (warm cache) 230ms -> 224ms (-3%) 1488ms -> 1824ms (+23%) 2367ms -> 2825ms (+19%)
CI install (warm cache, GVS disabled) 564ms -> 812ms (+44%) 1295ms -> 1920ms (+48%) 2361ms -> 2438ms (+3%)
CI install (cold cache, GVS disabled) 5800ms -> 3893ms (-33%) 4278ms -> 4221ms (-1%) 4823ms -> 4932ms (+2%)

daf6cbd vs ba7f671 | aube/bun/pnpm | 3 scenarios | 3 runs | 500mbit/50ms | generated by Codex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant