test(pnpm-import): port top-level-plugins parity test from pnpm misc.ts#433
test(pnpm-import): port top-level-plugins parity test from pnpm misc.ts#433
Conversation
8ba2afb to
c861e00
Compare
Greptile SummaryPorts two pnpm Confidence Score: 5/5Safe to merge — changes are limited to test files and registry fixtures with no production code modifications. No P0 or P1 findings. Both new bats tests are well-structured, follow existing conventions, and rely on registry fixtures confirmed present in the repo. The fixture dependency (@pnpm.e2e/dep-of-pkg-with-1-dep@100.0.0) exists in the test registry. The PR description mentions '11/37' while the code correctly shows '12/37', but this is only a description discrepancy — the code itself is accurate. No files require special attention. Important Files Changed
Reviews (4): Last reviewed commit: "test(pnpm-import): port not-top-level-pl..." | Re-trigger Greptile |
Verifies a top-level bin (`@pnpm.e2e/pkg-that-uses-plugins`) can
`require()` a sibling top-level package (`@pnpm.e2e/plugin-example`)
via Node's parent-`node_modules` walk. Both fixtures are already
mirrored in test/registry/storage/.
Also corrects PNPM_TEST_IMPORT.md: the `standard` package is needed
for misc.ts:204 ("not top-level packages"), not :190 — the line :190
test only needs the already-mirrored @pnpm.e2e/* fixtures.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…isc.ts Adds a minimal `aube-test-bin-uses-dep` fixture (one new package whose bin requires its own non-top-level dep) in lieu of mirroring pnpm's `standard@8.6.0` 170-package tree. Same property under test: top-level dep's bin resolves a regular (non-top-level) dep via Node's parent-`node_modules` walk under aube's isolated layout. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2707950 to
b04aea1
Compare
Benchmark changesVersions:
Public ratios: warm installs vs Bun 4x -> 9x; warm installs vs pnpm 5x -> 14x.
b04aea1 vs 164efb0 | aube/bun/pnpm | 3 scenarios | 3 runs | 500mbit/50ms | generated by Codex. |
Summary
@pnpm.e2e/pkg-that-uses-pluginsand@pnpm.e2e/plugin-exampleas siblings, then runs the bin viaaube run testand asserts the bin canrequire('@pnpm.e2e/plugin-example/package.json')from a sibling top-level dep — i.e. Node's parent-node_moduleswalk works correctly under aube's isolated layout.standard@8.6.0package is needed for misc.ts:204 (the next test, "not top-level packages should find the plugins they use"), not :190. Line :190 only needs the already-mirrored@pnpm.e2e/*fixtures.Test plan
mise run test:bats test/pnpm_install_misc.bats— all 11 tests pass.🤖 Generated with Claude Code
Note
Low Risk
Low risk: adds/updates Bats parity tests and a local registry fixture only, with no production code changes. Main risk is increased test/fixture maintenance and potential flakiness around Node module resolution expectations.
Overview
Ports additional pnpm
misc.tsparity coverage intotest/pnpm_install_misc.bats, adding assertions that (1) a top-level dependency’s bin canrequire()a sibling top-level package and (2) a top-level dependency’s bin can resolve its own non-top-level dependency via Node’s parent-node_moduleswalk.Adds a minimal local registry fixture (
aube-test-bin-uses-dep) to avoid mirroringstandard@8.6.0’s large transitive tree, and updatestest/PNPM_TEST_IMPORT.mdto reflect the new ported test count and document these two newly ported cases.Reviewed by Cursor Bugbot for commit b04aea1. Bugbot is set up for automated code reviews on this repo. Configure here.