Skip to content

docs(test): mark phase 0 done and refresh pnpm import status#429

Merged
jdx merged 1 commit intomainfrom
docs/pnpm-test-import-progress
Apr 30, 2026
Merged

docs(test): mark phase 0 done and refresh pnpm import status#429
jdx merged 1 commit intomainfrom
docs/pnpm-test-import-progress

Conversation

@jdx
Copy link
Copy Markdown
Contributor

@jdx jdx commented Apr 30, 2026

Summary

  • Check off Phase 0 — @pnpm.e2e/* fixtures (#424) and add_dist_tag helper (#422) both landed.
  • Record lifecycleScripts.ts 8/21 ported via #421 with a done/remaining split.
  • Relabel Phase 2 as unblocked (was "depends on add_dist_tag helper").
  • Refresh the conventions note now that the @pnpm.e2e/* fixtures are in-tree.

Test plan

  • doc-only — render check on GitHub

🤖 Generated with Claude Code


Note

Low Risk
Documentation-only updates to the pnpm test-import tracking doc; no runtime or test behavior changes.

Overview
Updates test/PNPM_TEST_IMPORT.md to mark Phase 0 infrastructure work as complete (mirrored @pnpm.e2e/* fixtures and the add_dist_tag helper), and records current Tier 1 progress for lifecycleScripts.ts (8/21 ported with done/remaining notes).

Renames Phase 2 as unblocked now that add_dist_tag exists, and refreshes the translation conventions to prefer using the in-tree @pnpm.e2e/* fixtures when specific package shapes are required.

Reviewed by Cursor Bugbot for commit 270cfc9. Bugbot is set up for automated code reviews on this repo. Configure here.

- Phase 0 fixtures (#424) and add_dist_tag (#422) checked off.
- lifecycleScripts.ts 8/21 ported (#421) with done/remaining split.
- Phase 2 relabeled unblocked now that add_dist_tag landed.
- Convention note updated: e2e fixtures are mirrored, prefer them
  when the test needs the specific shape.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 30, 2026

Greptile Summary

Doc-only update to test/PNPM_TEST_IMPORT.md: checks off Phase 0 (fixtures + add_dist_tag helper), records 8/21 progress on lifecycleScripts.ts with a done/remaining split, relabels Phase 2 as unblocked, and updates the package-substitution conventions to reflect the @pnpm.e2e/* fixtures now being in-tree. All content is accurate and consistent with the referenced PRs (#421, #422, #424).

Confidence Score: 5/5

Safe to merge — documentation-only change with no code impact.

Single markdown file updated with accurate status tracking; no logic, no code, no risk of breakage.

No files require special attention.

Important Files Changed

Filename Overview
test/PNPM_TEST_IMPORT.md Documentation update marking Phase 0 complete, recording lifecycleScripts.ts progress (8/21), unblocking Phase 2, and refreshing the package-substitution convention note.

Reviews (1): Last reviewed commit: "docs(test): mark phase 0 done and refres..." | Re-trigger Greptile

@jdx jdx merged commit e2c305f into main Apr 30, 2026
19 checks passed
@jdx jdx deleted the docs/pnpm-test-import-progress branch April 30, 2026 22:19
@github-actions
Copy link
Copy Markdown

Benchmark changes

Versions:

  • aube: 1.5.1 -> 1.5.2
  • pnpm: 11.0.2 -> 11.0.3

Public ratios: warm installs vs Bun 4x -> 5x; warm installs vs pnpm 5x -> 7x.

Benchmark aube bun pnpm
Fresh install (warm cache) 1021ms -> 609ms (-40%) 4134ms -> 2949ms (-29%) 4717ms -> 4100ms (-13%)
CI install (warm cache, GVS disabled) 2920ms -> 2468ms (-15%) 3396ms -> 2559ms (-25%) 4864ms -> 4342ms (-11%)
CI install (cold cache, GVS disabled) 10801ms -> 9393ms (-13%) 10012ms -> 10169ms (+2%) 9722ms -> 8363ms (-14%)

270cfc9 vs c30a8d7 | aube/bun/pnpm | 3 scenarios | 3 runs | 500mbit/50ms | generated by Codex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant