You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note: cargo clippy --all-targets -- -D warnings still reports the existing items_after_test_module warning in crates/aube/src/commands/install/mod.rs.
This PR was generated by Codex.
Note
Low Risk
Additive CLI feature that only reads existing lockfile data and adds new parsing/output paths; minimal impact on existing commands aside from command dispatch and docs regeneration.
Overview
Adds a new aube query command that reads the local lockfile, walks the reachable dependency graph (optionally scoped by workspace --filter and --prod/--dev roots), and filters packages via a selector expression supporting attribute predicates and pseudo-selectors like :scripts, :bin, :peer, :type(...), and :license(...).
The command can emit human-readable output, tab-separated --parseable rows, or --json output; CLI wiring, usage spec/docs generation (aube.usage.kdl, docs/cli/*), and new BATS coverage are included.
Reviewed by Cursor Bugbot for commit 780bcad. Bugbot is set up for automated code reviews on this repo. Configure here.
Adds a new read-only aube query command that walks the resolved lockfile graph and filters packages via a vlt-inspired selector syntax (*, [attr=value], :pseudo, chained and comma-separated groups). The selector parser, BFS traversal, and output formatters are well-implemented; issues flagged in prior review cycles (silent react:prod tokenisation, [bin=x] returning false) are fully addressed with tests.
Confidence Score: 5/5
Safe to merge — new read-only command with no impact on install, publish, or auth paths
Only P2 findings: deprecated missing from the flags() output (cosmetic inconsistency) and potential redundant BFS stack pushes in monorepos (performance, not correctness). All prior P1 issues are addressed.
crates/aube/src/commands/query.rs — specifically the flags() function and BFS stack deduplication in collect_entries
Important Files Changed
Filename
Overview
crates/aube/src/commands/query.rs
New query command — selector parsing is solid and previous thread issues are addressed; minor: flags() omits deprecated from the flags column, and direct deps may be pushed to the BFS stack multiple times in monorepos
crates/aube/src/main.rs
Wires Query variant into the clap enum and dispatch match — straightforward and consistent with other command registrations
test/query.bats
Two BATS integration tests covering name-filter and comma-separated selector groups; version assertions are flexible
aube.usage.kdl
Adds query command spec consistent with the Rust implementation and docs
docs/cli/query.md
Generated docs file — accurate and matches the implementation
docs/cli/commands.json
Auto-generated command registry entry — consistent with usage spec and Rust args
docs/cli/index.md
Adds aube query link in alphabetical order — correct placement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aube queryfor local selector-based dependency graph inspection inspired by vlt's dependency selector modelValidation
cargo fmt --checkcargo test -p aube query::testscargo test -p aube cli_ordering_tests::test_cli_orderingcargo clippy -p aube --bin aube --bin aubr --bin aubx -- -D warningsmise run test:bats test/query.batsmise run renderNote:
cargo clippy --all-targets -- -D warningsstill reports the existingitems_after_test_modulewarning incrates/aube/src/commands/install/mod.rs.This PR was generated by Codex.
Note
Low Risk
Additive CLI feature that only reads existing lockfile data and adds new parsing/output paths; minimal impact on existing commands aside from command dispatch and docs regeneration.
Overview
Adds a new
aube querycommand that reads the local lockfile, walks the reachable dependency graph (optionally scoped by workspace--filterand--prod/--devroots), and filters packages via a selector expression supporting attribute predicates and pseudo-selectors like:scripts,:bin,:peer,:type(...), and:license(...).The command can emit human-readable output, tab-separated
--parseablerows, or--jsonoutput; CLI wiring, usage spec/docs generation (aube.usage.kdl,docs/cli/*), and new BATS coverage are included.Reviewed by Cursor Bugbot for commit 780bcad. Bugbot is set up for automated code reviews on this repo. Configure here.