Skip to content

feat(pnpmfile): support esm pnpmfiles#362

Merged
jdx merged 4 commits intomainfrom
codex/pnpmfile-mjs
Apr 28, 2026
Merged

feat(pnpmfile): support esm pnpmfiles#362
jdx merged 4 commits intomainfrom
codex/pnpmfile-mjs

Conversation

@jdx
Copy link
Copy Markdown
Contributor

@jdx jdx commented Apr 28, 2026 •
edited by cursor Bot
Loading

Summary

  • prefer .pnpmfile.mjs over .pnpmfile.cjs during default pnpmfile discovery
  • load ESM pnpmfiles with dynamic import while preserving CommonJS require() support
  • document the new default lookup order and cover .mjs afterAllResolved/readPackage hooks

Validation

  • cargo test -p aube pnpmfile::tests
  • cargo build -p aube
  • mise run test:bats test/pnpmfile.bats
  • mise run docs:build
  • cargo fmt --check
  • git diff --check

Note

Medium Risk
Changes how pnpmfile hooks are discovered and executed (including dynamic ESM loading), which can affect dependency resolution behavior during installs if projects rely on existing hook semantics.

Overview
Adds support for ESM pnpmfiles by discovering and preferring .pnpmfile.mjs over .pnpmfile.cjs, while still honoring pnpmfilePath overrides.

Updates the Node hook shims to dynamically load .mjs via import() (and .cjs via require()), including a fallback when an ESM default export lacks hooks. Documentation/CLI help text and bats/unit tests are updated to reflect the new lookup order and to cover .mjs for both afterAllResolved and readPackage.

Reviewed by Cursor Bugbot for commit 38f6eb1. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 28, 2026 •
edited
Loading

Greptile Summary

This PR adds ESM pnpmfile support by preferring .pnpmfile.mjs over .pnpmfile.cjs during default discovery and loading .mjs files via dynamic import() while keeping CommonJS require() for .cjs files. The shared LOAD_PNPMFILE_JS helper eliminates the previous duplication between the two shims, the loadPnpmfile export-resolution logic correctly handles named-only, default-only, and mixed export shapes, and all docs/help text are updated consistently throughout.

Confidence Score: 5/5

Safe to merge — no logical, security, or behavioural regressions identified.

All changed code paths are well-tested (three new unit tests + three new bats integration tests), the JS export-resolution logic handles every realistic ESM export shape correctly, and the docs/help text are updated consistently. No P0 or P1 findings.

No files require special attention.

Important Files Changed

Filename Overview
crates/aube/src/pnpmfile.rs Core ESM pnpmfile support: adds shared LOAD_PNPMFILE_JS helper (dynamic import for .mjs, require for .cjs), updates detect() to prefer .pnpmfile.mjs, refactors both shims to use the shared loader, and adds three new unit tests covering .mjs-only and precedence scenarios.
test/pnpmfile.bats Adds three bats integration tests: .mjs priority over .cjs, named-hooks-win-when-default-has-no-hooks warning path, and readPackage from an .mjs default export — all scenarios align with the new shim logic.
crates/aube-manifest/src/workspace.rs Doc comment on pnpmfile_path field updated to reflect new .mjs-preferred, .cjs-fallback default discovery order.
crates/aube-settings/settings.toml Description and docs for pnpmfilePath updated to remove CJS-specific language and document the new .mjs → .cjs lookup order.
crates/aube/src/commands/install/mod.rs Help text and doc comments for --ignore-pnpmfile updated to mention both .pnpmfile.mjs and .pnpmfile.cjs.
aube.usage.kdl Help string for --ignore-pnpmfile updated to reference both .mjs and .cjs.
docs/cli/commands.json Generated CLI help text for --ignore-pnpmfile regenerated to match the new wording.
docs/cli/install.md Generated docs for --ignore-pnpmfile updated to mention both file types.
docs/settings/index.md Settings docs for pnpmfilePath updated to describe the .mjs-preferred default discovery order.

Reviews (4): Last reviewed commit: "fix(pnpmfile): avoid esm readPackage sta..." | Re-trigger Greptile

greptile-apps[bot]
greptile-apps Bot reviewed Apr 28, 2026
View reviewed changes
Comment thread crates/aube/src/pnpmfile.rs
Comment thread crates/aube/src/pnpmfile.rs
Comment thread crates/aube/src/pnpmfile.rs
cursor[bot]
cursor Bot reviewed Apr 28, 2026
View reviewed changes
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ed973b7. Configure here.

Comment thread crates/aube/src/pnpmfile.rs
@jdx jdx merged commit 8095b6b into main Apr 28, 2026
17 checks passed
@jdx jdx deleted the codex/pnpmfile-mjs branch April 28, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@cursor cursor[bot] cursor[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jdx