Greptile Summary

This PR fixes GVS installs where packages resolved via the canonical ~/.cache/aube/virtual-store/... path couldn't see the project-local hidden hoist, by mirroring hidden-hoist symlinks under virtual_store/node_modules/ in addition to the existing .aube/node_modules/ tree. The refactor introduces link_hidden_hoist_at, sweep_dead_hidden_hoist_entries, and friends to allow the shared GVS directory to remove only dead/dangling entries (rather than wiping the whole tree), preserving cross-project links. The core logic is sound and the existing reconcile_top_level_link correctly handles version-bump repointing.

Confidence Score: 5/5

Safe to merge; only P2 findings present, all relating to test coverage gaps rather than correctness defects in the new logic.

No new P0 or P1 issues found. The two P2 comments are about test coverage gaps (untested @scope/ live-link preservation path, and a cross-project hoist=false test that only exercises a single project). The implementation logic in sweep_dead_hidden_hoist_entries, sweep_dead_hidden_hoist_scope, and link_hidden_hoist_at is correct on inspection. The issues flagged in prior review rounds are known trade-offs documented in the PR and code comments.

No files require special attention beyond the test coverage gaps noted inline.

Important Files Changed

_{Reviews (5): Last reviewed commit: "fix(linker): mirror hidden hoist into gl..." | Re-trigger Greptile}

Addressed the shared-store race in 7b1c24f.

The project-local hidden hoist still does the wipe-and-repopulate because that directory is owned by one project. The shared GVS hidden hoist now runs additively: it preserves the existing virtual-store/node_modules/ directory, reconciles only the names present in the current graph, and skips fresh links. That avoids the concurrent-install window where one install could remove another install's shared hidden-hoist links.

Added test_global_virtual_store_hidden_hoist_is_additive to cover this path.

Validation:

• cargo fmt --check
• cargo test -p aube-linker test_global_virtual_store -- --nocapture
• cargo test -p aube-linker
• cargo clippy -p aube-linker --all-targets -- -D warnings

Addressed the follow-up feedback in 700e81c.

Changes:

• hoist=false now cleans the GVS hidden-hoist mirror instead of leaving old links active.
• The shared GVS mirror now prunes stale/removed names one entry at a time, rather than deleting the whole virtual-store/node_modules/ directory.
• Existing fresh links are still reconciled/skipped, so warm installs avoid unnecessary recreation.

Added coverage:

• test_global_virtual_store_hidden_hoist_prunes_by_entry
• test_global_virtual_store_hidden_hoist_cleans_when_disabled

Validation:

• cargo fmt --check
• cargo test -p aube-linker test_global_virtual_store_hidden_hoist -- --nocapture
• cargo test -p aube-linker
• cargo clippy -p aube-linker --all-targets -- -D warnings
• git diff --check

This comment was generated by Codex.

Addressed the cross-project removal issue in 17ce225.

The GVS hidden-hoist cleanup no longer uses the current project's graph as the complete preserve set. Instead, the shared virtual-store/node_modules/ cleanup now only removes broken entries: dangling symlinks or non-link junk. Live symlinks whose targets still exist are preserved, even when they belong to another project's graph. Current-project names are still reconciled normally, so version bumps or target changes for the active install get corrected.

I also updated the PR body to call out the upstream angle: packages with undeclared imports should ideally fix their manifests, but aube still needs GVS to match its existing hidden-hoist compatibility behavior for the ecosystem that already relies on hoisting.

Validation:

• cargo fmt --check
• cargo test -p aube-linker test_global_virtual_store_hidden_hoist -- --nocapture
• cargo test -p aube-linker
• cargo clippy -p aube-linker --all-targets -- -D warnings
• git diff --check

This comment was generated by Codex.

Addressed the latest cleanup feedback in 9f4f334.

• Scope-shaped entries in the shared GVS hidden hoist now verify that the @scope path is a real directory before treating it as a scope. Broken links, files, and other junk at that level go through the same dead-entry cleanup path.
• Dead hidden-hoist links now use the linker's dir-or-file removal helper, which covers Windows junction cleanup instead of only trying remove_file.
• Added a regression assertion for stale @scope-shaped entries.
• Rewrote the PR title and description to call out the upstream manifest issue and the conservative shared-GVS cleanup behavior.

Validation run locally:

• cargo fmt --check
• cargo test -p aube-linker test_global_virtual_store_hidden_hoist -- --nocapture
• cargo test -p aube-linker
• cargo clippy -p aube-linker --all-targets -- -D warnings
• git diff --check

This comment was generated by Codex.