fix: Fix build.sh failed if multiple sockets/files in a single directory.#28
Merged
Conversation
…TEMS_RW The Vesktop socket file is actually a normal file for some reason? And instead of adding only one ipc path, its possible to include multiple files/directories: https://github.com/ValveSoftware/steam-runtime/blob/master/doc/steamlinuxruntime-known-issues.md#sharing-directories-with-the-container This will be useful in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there are multiple files in a single directory that match discord ipc sockets name (Can be files or symlinks).
The scripts will failed to find any socket in that directory with the error
The first commit fix some warning with shellcheck
SC2155 (warning): Declare and assign separately to avoid masking return values.
SC3028 (warning): In POSIX sh, UID is undefined.
SC2144 (error): -S doesn't work with globs. Use a for loop.