Skip to content

Detect and set current working directory#95

Merged
endaaman merged 2 commits intoendaaman:masterfrom
js-everts:cwd
Feb 3, 2023
Merged

Detect and set current working directory#95
endaaman merged 2 commits intoendaaman:masterfrom
js-everts:cwd

Conversation

@js-everts
Copy link
Copy Markdown
Contributor

This adds 2 changes:

  1. Instead of defaulting to the daemon's working directory, All clients that are spawned will use the working directory of the command line invocation.
  2. Add a --working-directory option to override the working directory.

This might be considered a breaking change since it alters the default behavior of newly spawned clients.

Instead of defaulting to the daemon's working directory, make clients
use the working directory of the command line invocation.
Copy link
Copy Markdown
Owner

@endaaman endaaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't worry about CI failing (CircleCI's problem).

The name working-directory is redundant, so it is ok to be more simple such as --cwd. It would be very helpful if you could update the README as well.

@js-everts js-everts force-pushed the cwd branch 2 times, most recently from 95dd9d0 to 460ac12 Compare February 3, 2023 09:23
@js-everts
Copy link
Copy Markdown
Contributor Author

I've renamed --working-directory to --cwd. Let me know if you need further changes.

@endaaman endaaman merged commit 65f4c9b into endaaman:master Feb 3, 2023
@endaaman
Copy link
Copy Markdown
Owner

endaaman commented Feb 3, 2023

Thanks so much!

@erikLundstedt
Copy link
Copy Markdown
Contributor

I just needed exactly this feature, like a day ago

Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants