Skip to content

LuaJIT support#81

Merged
endaaman merged 6 commits intoendaaman:masterfrom
thalting:luajit
Sep 2, 2022
Merged

LuaJIT support#81
endaaman merged 6 commits intoendaaman:masterfrom
thalting:luajit

Conversation

@thalting
Copy link
Copy Markdown
Contributor

TODO: turn this into a build flag.

thalting added 2 commits June 17, 2022 15:00
fixes "PANIC: unprotected error in call to Lua API (attempt to index a nil value)"
@endaaman
Copy link
Copy Markdown
Owner

Thanks for the PR.

I think this should be the compile option to enbale by like --enable-luajit.

@thalting
Copy link
Copy Markdown
Contributor Author

how can I do this?

@endaaman
Copy link
Copy Markdown
Owner

What you have to do

  • Edit configure.ac, introduce --with-luajit option and define the flag that luajit is enabled or not.
  • Write LuaJIT-supported code along with the flag.
  • Fix Dockerfile or add new test suite for LuaJIT compilation.

@thalting
Copy link
Copy Markdown
Contributor Author

i don't know how to use autotools :/

@thalting
Copy link
Copy Markdown
Contributor Author

thalting commented Aug 5, 2022

--enable-luajit by @capezotte

@endaaman
Copy link
Copy Markdown
Owner

endaaman commented Aug 6, 2022

--enable-luajit and USES_LUAJIT are defined but it seems LuaJIT is not actually used.

@endaaman endaaman self-requested a review August 6, 2022 03:49
@thalting
Copy link
Copy Markdown
Contributor Author

thalting commented Aug 6, 2022

foo

@ecesar88
Copy link
Copy Markdown

ecesar88 commented Sep 2, 2022

merge?

@endaaman
Copy link
Copy Markdown
Owner

endaaman commented Sep 2, 2022

I wanted the review fixed. Anyway, it is OK. I will fix it.
Thanks for the PR!

@endaaman endaaman merged commit 708ab0d into endaaman:master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants