Added melody loop support#12
Merged
end2endzone merged 1 commit intoend2endzone:masterfrom Sep 29, 2021
elbowz:add-loop
Merged
Conversation
It allows the possibility to repeat the melody with a chosen gap between repetition
Owner
|
Hi. That is a great contribution. I am not sure that this feature would be a popular use case but I could be wrong. My point is that you can implement such a feature directly in What is certain is that your changes are backwards compatible so it wont hurt to integrate them. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It allows the possibility to repeat the melody with a chosen gap between repetition.
The number of repetition (
iLoopCount) and the gap (iLoopGap) can be passed to the functionbeginas optional params.This features was useful in a my little project (https://github.com/elbowz/thumbl-p), but I don't know if can be useful for others or it's well implemented.
I have used
noteDelayto add the pause/gap between repetition, so I don't know if it's so elegant coding.Anyway, thanks for you very useful and simple (to use) library!