Add include_router to Starlette and Router#2189
Closed
Lancetnik wants to merge 6 commits intoKludex:masterfrom
Closed
Add include_router to Starlette and Router#2189Lancetnik wants to merge 6 commits intoKludex:masterfrom
Lancetnik wants to merge 6 commits intoKludex:masterfrom
Conversation
Owner
|
That's really not what I mean. We have this related PR: #1988. |
Author
|
@Kludex did you talk about run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It's a PR connected with FastAPI nested lifespan bugfix.
So, there is a raw
include_routerimplementation to inherit it by the FastAPI next step.Also, it merge all nested by
mountapplications' events and lifespans to main application (#649).Checklist