BUG: wsgi.error should be TextIO, not BytesIO in WSGI transport#1828
Merged
lovelydinosaur merged 6 commits intoencode:masterfrom Sep 7, 2021
Merged
BUG: wsgi.error should be TextIO, not BytesIO in WSGI transport#1828lovelydinosaur merged 6 commits intoencode:masterfrom
lovelydinosaur merged 6 commits intoencode:masterfrom
Conversation
Contributor
|
Neat little, addition, yup! Thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this from here: https://github.com/falconry/falcon/blob/e255bff9ae5a90d0cb3fe9af7c16917f18a92dc3/falcon/request.py#L1879
Based on the documentation at https://modwsgi.readthedocs.io/en/master/user-guides/debugging-techniques.html#apache-error-log-files, I believe Falcon is right and HTTPX is wrong.
This PR:
BytesIO(wrong type of stream, can't be accessed by user) tosys.stderrso that users (or pytest automatically) will capture the logs.