Merged
Conversation
karpetrosyan
commented
Oct 25, 2023
T-256
reviewed
Oct 28, 2023
T-256
reviewed
Oct 28, 2023
T-256
reviewed
Nov 29, 2023
T-256
approved these changes
Nov 29, 2023
Co-authored-by: T-256 <132141463+T-256@users.noreply.github.com>
Contributor
Author
|
Now adding the There are some files that should be reformated with the new configurations, but to keep the PR simple and reviewable, I will update these lines after any approvals from the @encode/maintainers. |
Contributor
|
Okay, so the linting checks are currently failing here. I'd suggest we keep the max-line-length and get this merge on that basis, and then have a separate PR removing that and dealing with the line length changes that are required as a result. |
This reverts commit fd0ef87.
T-256
approved these changes
Dec 3, 2023
lovelydinosaur
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: encode/httpx#2901