Skip to content

refactor: simplify exponential_backoff#758

Merged
lovelydinosaur merged 6 commits intoencode:masterfrom
m9810223:master
Aug 3, 2023
Merged

refactor: simplify exponential_backoff#758
lovelydinosaur merged 6 commits intoencode:masterfrom
m9810223:master

Conversation

@m9810223
Copy link
Copy Markdown
Contributor

Summary

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

Copy link
Copy Markdown
Contributor

@lovelydinosaur lovelydinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 true.

could probably also do with a docstring.

@m9810223
Copy link
Copy Markdown
Contributor Author

let me add the docstring~

@m9810223 m9810223 requested a review from lovelydinosaur July 31, 2023 16:43
@karpetrosyan
Copy link
Copy Markdown
Contributor

Do we need changeloog?

@lovelydinosaur
Copy link
Copy Markdown
Contributor

Do we need changelog?

No, because it's not a behavioural change.

@lovelydinosaur lovelydinosaur merged commit 3cca055 into encode:master Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants