Add __eq__ method for permissions.OperandHolder class#8710
Merged
lovelydinosaur merged 1 commit intoencode:masterfrom Oct 17, 2022
Merged
Add __eq__ method for permissions.OperandHolder class#8710lovelydinosaur merged 1 commit intoencode:masterfrom
__eq__ method for permissions.OperandHolder class#8710lovelydinosaur merged 1 commit intoencode:masterfrom
Conversation
Contributor
|
🤷♂️. Okay. |
|
Just a passing note while reviewing an upgrade: should this not also be added to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason behind this proposal is to fully enable
permission_classescomparison, e.g. in tests:I'd love to submit an actual test, but being a first-time contributor here I'm not sure where and how exactly would it fit in just by looking at
tests/test_permissions.py.Have a nice day!