Merged
Conversation
FOXEERF722V4 ICM_42688P & ICM_42605 ; CAUTION / really no idea if this is anything good more ICM_42688P & ICM_42605 ; CAUTION / really no idea if this is anything good FOXEERF745V3_AIO
This was referenced May 21, 2023
…_nerdCopter_port' into 20230518_ICM426xx_Peck07_fixed_nerdCopter_port
… and obsolescence
BeauBrewski
reviewed
May 28, 2023
BeauBrewski
reviewed
May 28, 2023
BeauBrewski
reviewed
May 31, 2023
BeauBrewski
reviewed
May 31, 2023
BeauBrewski
reviewed
May 31, 2023
BeauBrewski
reviewed
May 31, 2023
| #define GYRO_ICM42688P_ALIGN GYRO_1_ALIGN | ||
| #define ICM42688P_CS_PIN GYRO_1_CS_PIN | ||
| #define ICM42688P_SPI_INSTANCE GYRO_1_SPI_INSTANCE | ||
|
|
Collaborator
There was a problem hiding this comment.
Since this is not defined as a dual gyro quad, and there is no GYRO_2, you cannot use defines for GYRO_1
#define GYRO_ICM42688P_ALIGN CW270_DEG
#define ACC_ICM42688P_ALIGN CW270_DEG
#define ICM42688P_CS_PIN PA4
#define ICM42688P_EXTI_PIN PC4
#define ICM42688P_SPI_INSTANCE SPI1
#define USE_MPU_DATA_READY_SIGNAL
#define ACC_MPU6000_ALIGN ACC_ICM42688P_ALIGN
#define GYRO_MPU6000_ALIGN GYRO_ICM42688P_ALIGN
#define MPU6000_CS_PIN ICM42688P_CS_PIN
#define MPU6000_SPI_INSTANCE ICM42688P_SPI_INSTANCE
#define MPU_INT_EXTI ICM42688P_EXTI_PIN
Don't need MPU6500 defines, and probably don't need the MPU6000 defines since pretty certain this is an ICM42xxxp specific target and FC
Member
Author
There was a problem hiding this comment.
BF shows mpu6000, but not 6500
Member
Author
There was a problem hiding this comment.
nope, i'm wrong, i keep mixing up 722_2022B with 405_2022B 🍌
BF:
#define BOARD_NAME MAMBAF405_2022B
#define MANUFACTURER_ID DIAT
#define USE_ACC
#define USE_ACC_SPI_MPU6000
#define USE_GYRO
#define USE_GYRO_SPI_MPU6000
#define USE_ACC_SPI_MPU6500
#define USE_GYRO_SPI_MPU6500
#define USE_GYRO_SPI_ICM42688P
#define USE_ACC_SPI_ICM42688P
BeauBrewski
reviewed
May 31, 2023
BeauBrewski
reviewed
May 31, 2023
BeauBrewski
reviewed
May 31, 2023
| #define UART4_RX_PIN PA1 | ||
| #define UART5_RX_PIN PD2 | ||
| #define UART6_RX_PIN PC7 | ||
| #define INVERTER_PIN_UART1 PC0 |
Collaborator
Member
Author
There was a problem hiding this comment.
so #define RSSI_ADC_PIN PC12 ???
Member
Author
|
ready for review/merge |
Quick-Flash
approved these changes
Jun 1, 2023
Member
Author
|
please see #890 (comment) i.e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WIPneeds testingmay need fixesmay need cleanup (especially GYRO_HARDWARE_LPF_* options)This code is ported from Betaflight. Thanks to Betaflight team and GPL licensed opensource.
https://github.com/betaflight/betaflight/blob/master/LICENSE
Massive thanks to @Peck07 for investigting and fixing some pre-existing failed works.
Massive thanks to @BeauBrewski for target definitions.
closes #869
Co-authored-by: tbolin tobias_bolin@hotmail.com
Co-authored-by: KarateBrot Rm2k-Freak@web.de
Co-authored-by: Steve Evans Steve@SCEvans.com
Co-authored-by: Dominic Clifton dominic.clifton@cleanflight.com
Co-authored-by: Peck07 28628457+Peck07@users.noreply.github.com
Co-authored-by: nerdCopter 56646290+nerdCopter@users.noreply.github.com