Skip to content
This repository was archived by the owner on Nov 1, 2021. It is now read-only.

Add missing library dependencies#170

Merged
kripken merged 1 commit intoemscripten-core:next-mergefrom
dylanmckay:next-merge
Feb 12, 2017
Merged

Add missing library dependencies#170
kripken merged 1 commit intoemscripten-core:next-mergefrom
dylanmckay:next-merge

Conversation

@dylanmckay
Copy link
Copy Markdown
Contributor

@dylanmckay dylanmckay commented Feb 12, 2017 •
edited
Loading

Without this, I get a bunch of 'undefined references' when linking.

This will merge into #166

@kripken
Copy link
Copy Markdown
Member

kripken commented Feb 12, 2017

Weird, I don't seem to need this change locally. I guess LLVMBuild is somehow dependent on the OS or something like that? Anyhow, seems safe to merge this.

@kripken kripken merged commit 11b1147 into emscripten-core:next-merge Feb 12, 2017
@dschuff
Copy link
Copy Markdown
Member

dschuff commented Feb 14, 2017

It may be dependent on whether or not you use -DBUILD_SHARED_LIBS and/or -DLLVM_LINK_LLVM_DYLIB and maybe also which OS.

@kripken
Copy link
Copy Markdown
Member

kripken commented Feb 14, 2017

Oh interesting, good to know.

@dylanmckay
Copy link
Copy Markdown
Contributor Author

dylanmckay commented Feb 15, 2017

That sounds about right, I compiled with -DBUILD_SHARED_LIBS

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dylanmckay @kripken @dschuff