Allow mutation of EXPORTED_RUNTIME_METHODS in JS libraries#26389
Open
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Open
Allow mutation of EXPORTED_RUNTIME_METHODS in JS libraries#26389sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
b8c634a to
ca587a1
Compare
This used to work in the past but regressed at some point. Fixes: emscripten-core#23057
ca587a1 to
4feb48a
Compare
kripken
approved these changes
Mar 5, 2026
|
|
||
| export function applySettings(obj) { | ||
| // Certain settings are read in as lists, but we convert them to Set | ||
| // within the compiler, for effeciency. |
Member
There was a problem hiding this comment.
Suggested change
| // within the compiler, for effeciency. | |
| // within the compiler, for efficiency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This used to work in the past but regressed at some point.
Fixes: #23057