Pass -Wno-character-conversion to gtest build#24350
Merged
dschuff merged 1 commit intoemscripten-core:mainfrom May 16, 2025
Merged
Pass -Wno-character-conversion to gtest build#24350dschuff merged 1 commit intoemscripten-core:mainfrom
dschuff merged 1 commit intoemscripten-core:mainfrom
Conversation
llvm/llvm-project#138708 added a new warning for converting different charN_t types, which trigger in the googletest build. Disable this warning until it's fixed upstream.
brendandahl
approved these changes
May 16, 2025
sbc100
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
llvm/llvm-project#138708 added a new warning for
converting different charN_t types, which triggers in the googletest
build. Disable this warning until it's fixed upstream.