[ci] Update linux image name from bionic to focal#23173
Merged
sbc100 merged 2 commits intoemscripten-core:mainfrom Dec 30, 2024
Merged
[ci] Update linux image name from bionic to focal#23173sbc100 merged 2 commits intoemscripten-core:mainfrom
sbc100 merged 2 commits intoemscripten-core:mainfrom
Conversation
cclauss
commented
Dec 16, 2024
sbc100
reviewed
Dec 16, 2024
| condition: ${CIRCLE_PULL_REQUEST} | ||
| steps: | ||
| set-retry-flaky-tests | ||
| - set-retry-flaky-tests |
Collaborator
There was a problem hiding this comment.
Does the old version not work?
Contributor
Author
There was a problem hiding this comment.
CircleCI flags this as an incorrect data type error which means it could easily stop working in future releases.
Collaborator
There was a problem hiding this comment.
Interesting, but they don't show it as a config error. I wonder why not? LGTM to this part either way.
Contributor
Author
There was a problem hiding this comment.
https://circleci.com/docs/vs-code-extension-overview/#config-helper is in-context help..
sbc100
approved these changes
Dec 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce confusion by using the correct Ubuntu release name. Currently, the tag is
bionicbut the image isfocal.https://releases.ubuntu.com
Should upgrading to Jammy 22.04 or Noble 24.04 be considered?
Also, resolve four problems raised by the VS Code extension for CircleCI: