Fix regal build after new clang warning was added. NFC#22814
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Oct 30, 2024
Merged
Fix regal build after new clang warning was added. NFC#22814sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
dschuff
approved these changes
Oct 30, 2024
Member
|
Are these new places that need updating showing up on CI, or how are you discovering them? |
Collaborator
Author
This showed up in emscripten CI yes. I guess we don't build regal as part of emscripten-releases? I guess this is because we don't do |
Collaborator
Author
|
The good news is that this means the llvm changed passed the rollers, and if i passes here too then we should be all good. |
Member
|
Ah yes, we use SYSTEM, and not ALL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #22798