Fix source map gen for relative include directories#20778
Merged
kripken merged 2 commits intoemscripten-core:mainfrom Dec 14, 2023
Merged
Fix source map gen for relative include directories#20778kripken merged 2 commits intoemscripten-core:mainfrom
kripken merged 2 commits intoemscripten-core:mainfrom
Conversation
Member
|
Thanks! This looks right to me, but please let's add testing for it (as discussed in #20776 (comment)). |
9353d4e to
5d6cd81
Compare
Contributor
Author
@kripken Added a test. Could you please take another look? |
kripken
approved these changes
Dec 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #20577, relative paths are used in command line to build system libraries.
As such, we need to properly handle those relative paths to generate a source map pointing to real source file locations.