Fix Ninja build on Windows#20556
Merged
RReverser merged 2 commits intoemscripten-core:mainfrom Oct 27, 2023
Merged
Conversation
Collaborator
|
We don't currently have any tests for EMCC_USE_NINJA.. so landing without test seems OK in this case. |
sbc100
approved these changes
Oct 27, 2023
`:` and ` ` are special from Ninja's PoV and need to be escaped with `$`, while `\` should be just converted to `/`. See emscripten-core#19079 (comment). I tested that this works on my Windows machine but not sure how to (and whether worth it) to test this on CI as well.
be158ac to
126ce05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:and space are special from Ninja's PoV and need to be escaped with$, while\should be just converted to/. See #19079 (comment).Also had to workaround ninja-build/ninja#53 (command line too long issue, which is common on Windows but apparently can happen on other OS too as limit is OS-specific) by utilising response file for archiving command.
I tested that this works on my Windows machine but not sure how to (and whether worth it) to test this on CI as well.