Always include library_sdl.js and library_glfw.js conditionally. NFC#19057
Always include library_sdl.js and library_glfw.js conditionally. NFC#19057
Conversation
f6996fe to
fe2c759
Compare
fe2c759 to
c328cc4
Compare
dschuff
left a comment
There was a problem hiding this comment.
I'm all for not having libraries magically included if not used; but we should probably have a changelog for this, right? Since this will break people who aren't using -lsdl or -lglfw if they should?
For glfw there is no change at all since USE_GLFW=2 is still the default. For USE_SDL, we changes the default to 0 back in #18443 so users have to opt into using SDL already. In other words I would argue this is very close to NFC. |
|
oh, they need to USE_SDL=1 to get the SDL C headers? |
Yes, as of #18443 that is needed. Users who don't specify |
c328cc4 to
7a0515c
Compare
Split out from #19028.
As of #18443, USE_SDL defaults to zero which means we don't want to include
library_sdl.js by default, even when
AUTO_JS_LIBRARIESis set.In order to make closure happy without
library_sdl.jsbut withINCLUDE_FULL_LIBRARYI had to add a closure type annotation for the
Module.ctxobject. I'm really not surewhy this was needed now but not before.