feat(embind): add support for type-based overloading#17445
Open
bugra9 wants to merge 1 commit intoemscripten-core:mainfrom
Open
feat(embind): add support for type-based overloading#17445bugra9 wants to merge 1 commit intoemscripten-core:mainfrom
bugra9 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
brendandahl
requested changes
Jul 21, 2022
Collaborator
brendandahl
left a comment
There was a problem hiding this comment.
For current consumers of the overload feature this is going to make things much slower, since there's a lot more work that will happen on every call to an overloaded function. Some thoughts on how we could improve this:
- First do a check for argument length, if there's only one method that matches call it. Otherwise, do the expensive type checking.
- There's a lot of split/joining and string matching. I think not relying on strings and keeping things split will be more efficient (see some comments inline).
Last, please update the documentation.
Author
|
Done. I refactored all my code performance-oriented and updated the documentation.
|
Author
|
Hi @brendandahl, do you have any suggestions? |
0fecb52 to
76a459b
Compare
76a459b to
60a0d81
Compare
60a0d81 to
074e3ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/runner other.test_embind.EMTEST_SKIP_V8=1 test/runner core0 skip:core0.test_time.