Fix .bat launcher to allow special characters#14260
Merged
Conversation
288465c to
a80525c
Compare
aheejin
approved these changes
May 22, 2021
Member
aheejin
left a comment
There was a problem hiding this comment.
Nice! Thank you for fixing my failed attempt 😅
| # only limited tests here, it's more efficient to build on demand | ||
| - run-tests: | ||
| test_targets: "other.test_emcc_cflags other.test_stdin other.test_bad_triple wasm2.test_sse1 wasm2.test_ccall other.test_closure_externs other.test_binaryen_debug other.test_js_optimizer_parse_error other.test_output_to_nowhere other.test_emcc_dev_null other.test_cmake* other.test_system_include_paths other.test_emar_response_file wasm2.test_utf16" | ||
| test_targets: "other.test_emcc_cflags other.test_stdin other.test_bad_triple wasm2.test_sse1 wasm2.test_ccall other.test_closure_externs other.test_binaryen_debug other.test_js_optimizer_parse_error other.test_output_to_nowhere other.test_emcc_dev_null other.test_cmake* other.test_system_include_paths other.test_emar_response_file wasm2.test_utf16 other.test_special_chars_in_arguments" |
Member
There was a problem hiding this comment.
What is this list of tests for?
Collaborator
Author
There was a problem hiding this comment.
This is subset of tests that we run on windows during github CI.
Using $* inside the if/else blocks here was confusing the bat file processor making it impossible to support commands that contains braces and exclamation points. There was an attempted fix made in #13723 which seemed hopefull but it prevented the exclamation point. Hopefully this will fix both cases. Thanks to Mysoft on discord for the suggestion. Fixes: #14063
Collaborator
Author
|
This failures are unrealted.. i think they are occurring because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
$*inside the if/else blocks here was confusing the bat fileprocessor making it impossible to support commands that contains braces
and exclamation points.
There was an attempted fix made in #13723 which seemed hopefull but it
prevented the exclamation point. Hopefully this will fix both cases.
Thanks to Mysoft on discord for the suggestion.
Fixes: #14063