Skip to content

Add --compiler-wrapper command line flag#12662

Merged
sbc100 merged 1 commit intomasterfrom
compiler_wrapper_command_line
Oct 31, 2020
Merged

Add --compiler-wrapper command line flag#12662
sbc100 merged 1 commit intomasterfrom
compiler_wrapper_command_line

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Oct 30, 2020

This works just like the COMPILER_WRAPPER config settings
but works from the command line.

Fixes: #12340

This works just like the COMPILER_WRAPPER config settings
but works from the command line.

Fixes: #12340
@sbc100
Copy link
Collaborator Author

sbc100 commented Oct 30, 2020

This change replaces #12608

@sbc100 sbc100 requested a review from kripken October 30, 2020 22:16
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, simpler and we can generalize later if needed I guess.

Please document it in emcc.rst and in the changelog.

(Given it's not general, it seems like this could be a setting in settings.js actually? If it's special maybe the PR as is is best.)

@sbc100
Copy link
Collaborator Author

sbc100 commented Oct 31, 2020

lgtm, simpler and we can generalize later if needed I guess.

Please document it in emcc.rst and in the changelog.

(Given it's not general, it seems like this could be a setting in settings.js actually? If it's special maybe the PR as is is best.)

That raises an interesting topic for discussion I think. If we want to add a user flag should we add it as an EmccOption or as a settings.js options... My mental model is that if the option only effects that python code in emcc.py then we should lean towards a new command line option. If the setting is needed also in JS then it needs to be in settings.js.

As a side node, adding things to settings JS unnecessarily also increases code size for users of RETAIN_COMPILER_SETTINGS.

@sbc100 sbc100 merged commit 693c656 into master Oct 31, 2020
@sbc100 sbc100 deleted the compiler_wrapper_command_line branch October 31, 2020 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replacement for deprecated EMMAKEN_COMPILER?

2 participants