Use the setup function from ember-prism#51
Merged
mansona merged 3 commits intoempress:mainfrom Aug 31, 2023
Merged
Conversation
✅ Deploy Preview for ember-showdown-prism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like it's working, but the theme in the dummy app isn't utilizing all the named tokens:
the
handlebarslanguage has been replaced byglimmerso that all our existing code doesn't need changing.Also, using the
glimmerlanguage on code fences shows no changes in the highlighting (proving they're the same parser)To better show the difference, I added more to the example.md (if you want this removed in the PR, that's fine, too)
Before
(handlebars)
Not yet
(handlebars + glimmer (they fight each other))
After
(glimmer only)
it's not perfect but it's an improvement over handlebars (which ember doesn't use)
On the ember website: https://guides.emberjs.com/release/in-depth-topics/rendering-values/
All of this should have some color after updating