Fix DMI file access error messages by suppressing stderr output #1932
+5
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_machine()function in the admin module was generating error messages when DMI files didn't exist on certain systems (containers, virtual machines, etc.). These error messages were being displayed to users even though the function was designed to handle missing files gracefully.Problem
When DMI files like
/sys/devices/virtual/dmi/id/board_vendordon't exist, thecatcommands would output error messages to stderr:Solution
Modified the
get_machine()function inModules/admin/admin_model.phpto redirect stderr to/dev/nullfor all DMI file read operations. This suppresses the error messages while maintaining all existing functionality.Before:
After:
Testing
The fix is minimal and surgical - it only adds
2>/dev/nullto suppress stderr output while maintaining all existing functionality for systems where DMI files are available.Fixes #1907.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.