Skip to content

Feat/allow to add all members#1

Open
emmava46 wants to merge 4 commits intomainfrom
feat/allow-to-add-all-members
Open

Feat/allow to add all members#1
emmava46 wants to merge 4 commits intomainfrom
feat/allow-to-add-all-members

Conversation

@emmava46
Copy link
Copy Markdown
Owner

@emmava46 emmava46 commented Sep 13, 2023

What does this PR do?

Fixes calcom#10991

This PR aims to add a new toggle button, to allow creating event type that will automatically add all members, even the one that will join the team in the future.

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

Copy link
Copy Markdown
Owner Author

@emmava46 emmava46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is not handling the part where the flag addAllMembers is taken into account to send the events to all members of a team.
I was not able to make the code compile with only the toggle button (but forgot to take screen), but after trying to add the query + model part, the code is not compiling anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-2611] team events: automatically add this to all members

1 participant