refactor: Initial cleanup of new PCA OBS source code #3
Merged
steinnhauser merged 23 commits intomainfrom Nov 25, 2024
Merged
Conversation
for more information, see https://pre-commit.ci
…e size of indentation tree
…ove more unused variables and imports, add some types
…et data from, how we call functions, how we assert outputs
…ogging to use mne logger instead of prints, add wrapper method in front of private _pca_obs method to handle parallel processing
… to have consistent patterns
Collaborator
Author
|
Initial cleanup can be considered completed, need to write tests in upcoming MR (likely !5) |
Collaborator
Author
|
Continuing development in #5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for more information, see https://pre-commit.ci
Reference issue (if any)
What does this implement/fix?
Additional information