Fix: When the program is minimized, the viewport stops working.#4487
Closed
rustbasic wants to merge 9 commits intoemilk:masterfrom
Closed
Fix: When the program is minimized, the viewport stops working.#4487rustbasic wants to merge 9 commits intoemilk:masterfrom
rustbasic wants to merge 9 commits intoemilk:masterfrom
Conversation
emilk
reviewed
May 20, 2024
Owner
emilk
left a comment
There was a problem hiding this comment.
Have you tested this thoroughly with test_viewports?
| let mut glutin = self.glutin.borrow_mut(); | ||
| let original_viewport = &glutin.viewports[&viewport_id]; | ||
|
|
||
| // This will only happens when a Immediate Viewport. |
| return EventResult::Wait; | ||
| }; | ||
|
|
||
| // This will only happens when a Immediate Viewport. |
Owner
There was a problem hiding this comment.
Suggested change
| // This will only happens when a Immediate Viewport. |
Contributor
Author
Yes, I tested it for a long time on Windows 10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: When the program is minimized, the viewport stops working.