For keep the border so we know where TextEdit exists.#4242
Closed
rustbasic wants to merge 33 commits intoemilk:masterfrom
Closed
For keep the border so we know where TextEdit exists.#4242rustbasic wants to merge 33 commits intoemilk:masterfrom
TextEdit exists.#4242rustbasic wants to merge 33 commits intoemilk:masterfrom
Conversation
TextEdit exists.TextEdit exists.
Owner
|
Can you show an before-and-after image of the default egui style with this change? |
Contributor
Author
Owner
Contributor
Author
|
Seeing screenshots of your heavily customized app is not helpful. There are pros and cons, but I think the advantage of knowing that TextEdit exists there is greater. |
Owner
|
Let's make it an option - this should be up to the user to chose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




For keep the border so we know where
TextEditexists.