Skip to content

For keep the border so we know where TextEdit exists.#4242

Closed
rustbasic wants to merge 33 commits intoemilk:masterfrom
rustbasic:patch32
Closed

For keep the border so we know where TextEdit exists.#4242
rustbasic wants to merge 33 commits intoemilk:masterfrom
rustbasic:patch32

Conversation

@rustbasic
Copy link
Copy Markdown
Contributor

@rustbasic rustbasic commented Mar 27, 2024

For keep the border so we know where TextEdit exists.

@rustbasic rustbasic changed the title For Keep the border so we know where TextEdit exists. For keep the border so we know where TextEdit exists. Mar 27, 2024
@emilk
Copy link
Copy Markdown
Owner

emilk commented Mar 30, 2024

Can you show an before-and-after image of the default egui style with this change?

@rustbasic
Copy link
Copy Markdown
Contributor Author

rustbasic commented Mar 31, 2024

This is the image I posted before.
There is a lrectangle line in the input section at the end.
It would be better to know that TextEdit exists.

By the way, can I use ui.visuals().widgets.noninteractive.bg_Stroke?

Before :

explain20240313-1

After :

explain20240312

@emilk
Copy link
Copy Markdown
Owner

emilk commented Apr 21, 2024

Seeing screenshots of your heavily customized app is not helpful.

This is what I'm interested in:

Before this PR:
Screenshot 2024-04-21 at 11 59 24

After this PR:
Screenshot 2024-04-21 at 11 58 58

Now I understand what the change is. I can see the benefits (better readability) and the downsides (its uglier)

@rustbasic
Copy link
Copy Markdown
Contributor Author

Seeing screenshots of your heavily customized app is not helpful.
=> Sorry about that. but, I don't have enough time to even edit images.

There are pros and cons, but I think the advantage of knowing that TextEdit exists there is greater.

@emilk
Copy link
Copy Markdown
Owner

emilk commented Apr 21, 2024

Let's make it an option - this should be up to the user to chose

@rustbasic rustbasic closed this Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants