egui-winit: Don't treat WindowEvent::CloseRequested as consumed#3627
Merged
emilk merged 1 commit intoemilk:masterfrom Nov 26, 2023
Merged
egui-winit: Don't treat WindowEvent::CloseRequested as consumed#3627emilk merged 1 commit intoemilk:masterfrom
WindowEvent::CloseRequested as consumed#3627emilk merged 1 commit intoemilk:masterfrom
Conversation
This appears to have been 'consumed' by the viewport changes at one point (by updating `viewport_info`), but this is no longer the case. We should avoid marking this as 'consumed', so that applications know to continue processing this event after passing it to egui.
emilk
approved these changes
Nov 26, 2023
WindowEvent::CloseRequested as consumed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This appears to have been 'consumed' by the viewport changes at one point (by updating
viewport_info), but this is no longer the case. We should avoid marking this as 'consumed', so that applications know to continue processing this event after passing it to egui.