Move IME candidate window following text cursor#258
Merged
emilk merged 5 commits intoemilk:masterfrom Mar 30, 2021
n2:ime
Merged
Move IME candidate window following text cursor#258emilk merged 5 commits intoemilk:masterfrom n2:ime
emilk merged 5 commits intoemilk:masterfrom
n2:ime
Conversation
Owner
|
This looks great! Let me know when it is ready for review. |
Contributor
Author
|
Well, it is done. Thera is a little bug in composition events part on mobile devices, so it will be commited latter. @emilk |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now IME candidate window can move with text cursor, both on web(laptop/desktop) and native app.This is part of the work at #248 , it is relatively simple and independent of the rest of the work, a separate PR is submitted.