Add module field to package.json#49
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Aug 4, 2017
aduth:add/package-json-module
Merged
Add module field to package.json#49rwjblue merged 1 commit intoemberjs:masterfrom aduth:add/package-json-module
rwjblue merged 1 commit intoemberjs:masterfrom
aduth:add/package-json-module
Conversation
Contributor
Author
|
Might also be interesting to investigate https://github.com/webpack/webpack/tree/feature/pure-module/examples/pure-module I'm not very familiar with it yet. |
Member
|
Thanks! This seems good to me... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request seeks to add a
modulefield to thepackage.json, to allow automatic detection and ES2015 module resolution by Webpack 2+ and Rollup:It's possible to configure either to pick up the existing
jsnext:main, but (a) it'd be nice to be picked up by default without additional configuration and (b) in my experience libraries which opt in tojsnext:maindon't always transpile, so requires further configuration to apply Babel (and the right Babel configuration) tonode_modules. Since it appears that thedist/es6is already transpiled save ES2015 modules (sorry, not very familiar with TypeScript nor Ember CLI), this should work fine as-is.