Skip to content

Advance RFC #0726 "DOM Element descriptor interface for test helpers" to Stage Released#1004

Merged
ef4 merged 5 commits intomasterfrom
advance-rfc-0726
Jul 12, 2024
Merged

Advance RFC #0726 "DOM Element descriptor interface for test helpers" to Stage Released#1004
ef4 merged 5 commits intomasterfrom
advance-rfc-0726

Conversation

@emberjs-rfcs-bot
Copy link
Collaborator

@emberjs-rfcs-bot emberjs-rfcs-bot commented Jan 26, 2024

Advance #726 to the Released Stage

Rendered

Summary

This pull request is advancing the RFC to the Released Stage.

Upon merging this PR, automation will open a draft PR for this RFC to move to the Recommended Stage.

Released Stage Summary

The work is published. If it is codebase-related work, it is in a stable version of the relevant package(s). If there are any critical deviations from the original RFC, they are briefly noted at the top of the RFC.

If the work for an RFC is spread across multiple releases of Ember or other packages, the RFC is considered to be in the Released stage when all features are available in stable releases and those packages and versions are noted in the RFC frontmatter.

Ember's RFC process can be used for process and work plans that are not about code. Some examples include Roadmap RFCs, changes to the RFC process itself, and changes to learning resources. When such an RFC is a candidate for Released, the work should be shipped as described, and the result should presented to the team with the intent of gathering feedback about whether anything is missing. If there is agreement that the work is complete, the RFC may be marked "Released" and a date is provided instead of a version.

An RFC is moved into "Released" when the above is verified by consensus of the relevant team(s) via a PR to update the stage.

Checklist to move to Released

  • The work is published in stable versions of the relevant package(s), with any feature flags toggled on.
  • Deviations from the original RFC are noted in the RFC
  • Release packages and dates are updated in the RFC frontmatter

@emberjs-rfcs-bot emberjs-rfcs-bot added RFC Advancement S-Released PR to move to the Released Stage labels Jan 26, 2024
@ef4
Copy link
Contributor

ef4 commented Jan 26, 2024

@bendemboski please comment here when the releases are out for this. Thanks.

@achambers achambers assigned achambers and bendemboski and unassigned achambers Feb 21, 2024
@achambers
Copy link
Contributor

Any updates on this @bendemboski ?

@bendemboski
Copy link
Collaborator

bendemboski commented Mar 13, 2024

@ef4
Copy link
Contributor

ef4 commented Apr 23, 2024

Discussion at tooling meeting today was hashing out the implementation strategy to unblock the qunit-dom feature. We have a consensus plan on a pluggable implementation in qunit-dom that meets everybody's needs.

@ef4
Copy link
Contributor

ef4 commented Jun 28, 2024

I see that a release of qunit-dom went out, @bendemboski what remains to be released?

@bendemboski
Copy link
Collaborator

@ef4 nothing! I've updated the checklist above, however I'd like to hold off on declaring victory until I can update the test app in fractal-page-object to use the newly-released qunit-dom rather than patching my changes in locally, just to prove that it's all working end-to-end. I should be able to get to that very soon -- next few days certainly.

@bendemboski
Copy link
Collaborator

@ef4 I just release v1.0 of fractal-page-object which now gives a working end-to-end implementation of this RFC -- page objects from fractal-page-object can be passed directly to @ember/test-helpers' DOM helpers and qunit-dom's assertions.

For the last checklist item above -- (Release packages and dates are updated in the RFC frontmatter), do I open another PR into this repo to update the dates? Or what's next here?

@ef4
Copy link
Contributor

ef4 commented Jul 11, 2024

Thanks, I edited the release versions directly into this PR.

@ef4 ef4 marked this pull request as ready for review July 11, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RFC Advancement S-Released PR to move to the Released Stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants