Skip to content

[Bugfix LTS] Add @ember/reactive into the AMD bundles#21024

Merged
ef4 merged 3 commits intomainfrom
nvp/ember-reactive-in-amd
Jan 6, 2026
Merged

[Bugfix LTS] Add @ember/reactive into the AMD bundles#21024
ef4 merged 3 commits intomainfrom
nvp/ember-reactive-in-amd

Conversation

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

@NullVoxPopuli NullVoxPopuli commented Jan 6, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 6, 2026 •
edited
Loading

Estimated Asset Sizes

Diff



Details


This PRmain





╔═══════╤═══════════╤═══════════╗
║       │ Min       │ Gzip      ║
╟───────┼───────────┼───────────╢
║ Total │ 352.11 KB │ 203.55 KB ║
╚═══════╧═══════════╧═══════════╝

╔══════════════════════╤═══════════╤══════════╗
║ @ember/*             │ Min       │ Gzip     ║
╟──────────────────────┼───────────┼──────────╢
║ Total                │ 313.81 KB │ 181.8 KB ║
╟──────────────────────┼───────────┼──────────╢
║ -internals           │ 36.61 KB  │ 26 KB    ║
║ application          │ 13.24 KB  │ 8.03 KB  ║
║ array                │ 13.05 KB  │ 7.54 KB  ║
║ canary-features      │ 304 B     │ 419 B    ║
║ component            │ 2.05 KB   │ 1.57 KB  ║
║ controller           │ 1.96 KB   │ 1.45 KB  ║
║ debug                │ 11.73 KB  │ 8.14 KB  ║
║ deprecated-features  │ 31 B      │ 77 B     ║
║ destroyable          │ 561 B     │ 383 B    ║
║ enumerable           │ 259 B     │ 387 B    ║
║ helper               │ 1.08 KB   │ 830 B    ║
║ instrumentation      │ 2.43 KB   │ 1.78 KB  ║
║ modifier             │ 1.22 KB   │ 987 B    ║
║ object               │ 35.98 KB  │ 22.1 KB  ║
║ owner                │ 159 B     │ 178 B    ║
║ renderer             │ 630 B     │ 491 B    ║
║ routing              │ 59.37 KB  │ 33.91 KB ║
║ runloop              │ 2.36 KB   │ 1.5 KB   ║
║ service              │ 1 KB      │ 858 B    ║
║ template             │ 654 B     │ 538 B    ║
║ template-compilation │ 429 B     │ 366 B    ║
║ template-compiler    │ 123.33 KB │ 59.68 KB ║
║ template-factory     │ 370 B     │ 351 B    ║
║ test                 │ 923 B     │ 627 B    ║
║ utils                │ 4.11 KB   │ 3.63 KB  ║
║ version              │ 55 B      │ 131 B    ║
╚══════════════════════╧═══════════╧══════════╝

╔═════════════════╤══════════╤══════════╗
║ @glimmer/*      │ Min      │ Gzip     ║
╟─────────────────┼──────────┼──────────╢
║ Total           │ 38.29 KB │ 21.76 KB ║
╟─────────────────┼──────────┼──────────╢
║ destroyable     │ 2.78 KB  │ 1.38 KB  ║
║ encoder         │ 81 B     │ 171 B    ║
║ env             │ 38 B     │ 87 B     ║
║ global-context  │ 886 B    │ 545 B    ║
║ manager         │ 977 B    │ 627 B    ║
║ node            │ 175 B    │ 249 B    ║
║ opcode-compiler │ 1.11 KB  │ 905 B    ║
║ owner           │ 159 B    │ 202 B    ║
║ program         │ 252 B    │ 333 B    ║
║ reference       │ 548 B    │ 544 B    ║
║ runtime         │ 10.32 KB │ 5.22 KB  ║
║ tracking        │ 1.34 KB  │ 1.18 KB  ║
║ util            │ 1.85 KB  │ 1.59 KB  ║
║ validator       │ 15.53 KB │ 6.9 KB   ║
║ vm              │ 495 B    │ 569 B    ║
║ wire-format     │ 1.84 KB  │ 1.35 KB  ║
╚═════════════════╧══════════╧══════════╝




╔═══════╤═══════════╤═══════════╗
║       │ Min       │ Gzip      ║
╟───────┼───────────┼───────────╢
║ Total │ 352.11 KB │ 203.55 KB ║
╚═══════╧═══════════╧═══════════╝

╔══════════════════════╤═══════════╤══════════╗
║ @ember/*             │ Min       │ Gzip     ║
╟──────────────────────┼───────────┼──────────╢
║ Total                │ 313.81 KB │ 181.8 KB ║
╟──────────────────────┼───────────┼──────────╢
║ -internals           │ 36.61 KB  │ 26 KB    ║
║ application          │ 13.24 KB  │ 8.03 KB  ║
║ array                │ 13.05 KB  │ 7.54 KB  ║
║ canary-features      │ 304 B     │ 419 B    ║
║ component            │ 2.05 KB   │ 1.57 KB  ║
║ controller           │ 1.96 KB   │ 1.45 KB  ║
║ debug                │ 11.73 KB  │ 8.14 KB  ║
║ deprecated-features  │ 31 B      │ 77 B     ║
║ destroyable          │ 561 B     │ 383 B    ║
║ enumerable           │ 259 B     │ 387 B    ║
║ helper               │ 1.08 KB   │ 830 B    ║
║ instrumentation      │ 2.43 KB   │ 1.78 KB  ║
║ modifier             │ 1.22 KB   │ 987 B    ║
║ object               │ 35.98 KB  │ 22.1 KB  ║
║ owner                │ 159 B     │ 178 B    ║
║ renderer             │ 630 B     │ 491 B    ║
║ routing              │ 59.37 KB  │ 33.91 KB ║
║ runloop              │ 2.36 KB   │ 1.5 KB   ║
║ service              │ 1 KB      │ 858 B    ║
║ template             │ 654 B     │ 538 B    ║
║ template-compilation │ 429 B     │ 366 B    ║
║ template-compiler    │ 123.33 KB │ 59.68 KB ║
║ template-factory     │ 370 B     │ 351 B    ║
║ test                 │ 923 B     │ 627 B    ║
║ utils                │ 4.11 KB   │ 3.63 KB  ║
║ version              │ 55 B      │ 131 B    ║
╚══════════════════════╧═══════════╧══════════╝

╔═════════════════╤══════════╤══════════╗
║ @glimmer/*      │ Min      │ Gzip     ║
╟─────────────────┼──────────┼──────────╢
║ Total           │ 38.29 KB │ 21.76 KB ║
╟─────────────────┼──────────┼──────────╢
║ destroyable     │ 2.78 KB  │ 1.38 KB  ║
║ encoder         │ 81 B     │ 171 B    ║
║ env             │ 38 B     │ 87 B     ║
║ global-context  │ 886 B    │ 545 B    ║
║ manager         │ 977 B    │ 627 B    ║
║ node            │ 175 B    │ 249 B    ║
║ opcode-compiler │ 1.11 KB  │ 905 B    ║
║ owner           │ 159 B    │ 202 B    ║
║ program         │ 252 B    │ 333 B    ║
║ reference       │ 548 B    │ 544 B    ║
║ runtime         │ 10.32 KB │ 5.22 KB  ║
║ tracking        │ 1.34 KB  │ 1.18 KB  ║
║ util            │ 1.85 KB  │ 1.59 KB  ║
║ validator       │ 15.53 KB │ 6.9 KB   ║
║ vm              │ 495 B    │ 569 B    ║
║ wire-format     │ 1.84 KB  │ 1.35 KB  ║
╚═════════════════╧══════════╧══════════╝









      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @ef4






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

              
  
      
                Copy Markdown

  

        
      

    


    

        

  
    Contributor


        

    

  


  

    

      
          
      

      
            ef4
  

      

      

      commented


        Jan 6, 2026


      
    


  





      


        



  
    

      
          
I think if you add a unit test in smoke-tests/scenarios/basic-test.ts it will reproduce the failure and show the fix working.


      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
        





      

  
          

  
  

  
      @NullVoxPopuli
  NullVoxPopuli


        force-pushed
    the
        
      
  nvp/ember-reactive-in-amd


    
 branch
    from
    d033cdb    to
    93f06b6      
    Compare
  



    January 6, 2026 22:14    
    









      

  
        





      

  
          
 
  

    
  

  


        
        @ef4
  ef4



        merged commit df4f258
      into

      
  
    main
  


    Jan 6, 2026

      

        29 checks passed
      


      

        
  
          
  
    
    


  
      

  







  

  
  

  
      @ef4
  ef4


    
    deleted the
    
      
        nvp/ember-reactive-in-amd
    
    branch

    January 6, 2026 22:42    
    













  
  

    

      

  










  








  
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  










      

  

    
    

    

  

    Reviewers
  


    

    No reviews






    
    
    

    

  


      
  

    Assignees
  



        


    No one assigned







      


  


  

    Labels
  



    

    None yet







      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
  

    Development
  



            


Successfully merging this pull request may close these issues.





  
  



      
    

  




      

    

  
        

  

    

      2 participants
    

    

        
          @NullVoxPopuli 
        
          @ef4