[FEATURE] Create public import for uniqueId helper #20171 #20464
Merged
wagenet merged 4 commits intoemberjs:mainfrom Jun 7, 2023
Merged
[FEATURE] Create public import for uniqueId helper #20171 #20464wagenet merged 4 commits intoemberjs:mainfrom
wagenet merged 4 commits intoemberjs:mainfrom
Conversation
Adding test and also re-organizing the export Correcting to single quotes correct test description adding empty line to adhere to linting address lint place on global addressed comments to use invokeHelper
NullVoxPopuli
commented
May 28, 2023
| // always starts with a letter, to avoid creating invalid IDs with a numeric | ||
| // digit at the start. | ||
| function uniqueId() { | ||
| export function uniqueId(): string { |
Contributor
Author
There was a problem hiding this comment.
this return type was previously any
11 tasks
ef4
reviewed
Jun 6, 2023
ef4
approved these changes
Jun 6, 2023
wagenet
approved these changes
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebases: #20171
Additional changes:
uniqueId, rather than the helper, because this is better. We don't need the classic Helper infra ever since native functions became supported in 4.5 (this was pending feedback on Create public import foruniqueIdhelper #20171)_invokeHelperto the Ember global -- I don't think we don't want to keep adding to that object, because it makes future stuff and tree shaking harder (or forces us to have even more build time complexity)Resolves: #20165
Locally,