[CLEANUP beta] Inelegant throw for arg-less-paren-less helper#19843
Merged
mixonic merged 1 commit intoemberjs:masterfrom Nov 14, 2021
Merged
[CLEANUP beta] Inelegant throw for arg-less-paren-less helper#19843mixonic merged 1 commit intoemberjs:masterfrom
mixonic merged 1 commit intoemberjs:masterfrom
Conversation
rwjblue
approved these changes
Nov 14, 2021
Member
Author
|
I'm taking @rwjblue's approval and merging. I have opened an issue upstream in Glimmer-VM for the cleanup to either improve this error message or change functionality. See glimmerjs/glimmer-vm#1363 @chancancode I would still value your opinion, and I'm happy to do some more followup if you think it is critical for 4.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #19617
Convert the deprecation for
argument-less-helper-paren-less-invocationinto athrow. A more elegant version of this fix would convert the deprecation upstream in Glimmer VM into an assert, or would update the syntax to match a more desired functionality. I've taken a quick stab at that, but wasn't able to come up with something I was happy with quickly.I suggest we land this for 4.0, and we can continue to improve the message in the
throw, or remove thethrow, or add anassertinstead at the Glimmer VM level, in followup patches.