Remove assertion if model has no find method in implicit record loading#19840
Closed
snewcomer wants to merge 4 commits intoemberjs:masterfrom
Closed
Remove assertion if model has no find method in implicit record loading#19840snewcomer wants to merge 4 commits intoemberjs:masterfrom
find method in implicit record loading#19840snewcomer wants to merge 4 commits intoemberjs:masterfrom
Conversation
find method in implicit record loading
Contributor
Author
|
I guess other pkgs could have a a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#19545
warp-drive-data/warp-drive#7744 (comment)
There is no
findmethod on model class instances. Ideally this change to early return was made when ember-data removed thefindmethod from model instances - see here for old definition.