[CLEANUP beta] remove the --test-type option from the helper blueprint#19808
Merged
rwjblue merged 2 commits intoemberjs:masterfrom Nov 4, 2021
Merged
Conversation
Rendering tests are the recommended test type for helpers.
It seems the previous version of the blueprints produced some extra whitespace which can now be removed.
Windvis
commented
Oct 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
--test-typeoption from the helper blueprint. The unit test blueprint has been broken for a while now, and it was suggested that this option should be removed since rendering tests are the recommended testing type for helpers.Closes #18245