[CLEANUP beta] remove addArrayObserver#19746
Closed
snewcomer wants to merge 1 commit intoemberjs:masterfrom
Closed
[CLEANUP beta] remove addArrayObserver#19746snewcomer wants to merge 1 commit intoemberjs:masterfrom
snewcomer wants to merge 1 commit intoemberjs:masterfrom
Conversation
b9d2b32 to
70ba04a
Compare
70ba04a to
324163b
Compare
324163b to
9aadb6d
Compare
Member
|
@snewcomer I believe we've gotten a version of this green in #19833. There is definitely further work, and this PR was extremely helpful as a roadmap for what the scope of changes would be. In general in the other PR I did try to be as conservative as possible about changes, even so I ran into some gnarly leaky interfaces. Thank you for getting this going! Your review on the other PR would be very helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #19617
Deprecation: https://deprecations.emberjs.com/v3.x/#toc_array-observers
RFC: emberjs/rfcs#692
WIP