[ci]: @ember/test-helpers partner test#19728
Closed
snewcomer wants to merge 20 commits intoemberjs:mainfrom
Closed
[ci]: @ember/test-helpers partner test#19728snewcomer wants to merge 20 commits intoemberjs:mainfrom
snewcomer wants to merge 20 commits intoemberjs:mainfrom
Conversation
796e676 to
76a5b30
Compare
76a5b30 to
177b3f1
Compare
177b3f1 to
8e44598
Compare
8e44598 to
4391273
Compare
2b51bec to
95cf534
Compare
Contributor
Author
|
@stefanpenner This is ready for your review! cc @rwjblue |
86d0913 to
993ae85
Compare
71fca81 to
62201b0
Compare
5 tasks
b4b367b to
67990ba
Compare
Contributor
Author
|
@stefanpenner Just a friendly ping. This is ready for your review based on our discussion here - #19680 (comment) |
131f7a1 to
b9a2a43
Compare
Member
|
Is this still relevant? |
Member
|
Closing; we now have smoke tests that aren't exactly this but should catch this type of issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #19680 (comment)
This PR adds smoke tests for ember-test-helpers, ember-string and ember-legacy-built-in-components when a PR is opened to ensure no regressions in those repos.