[CLEANUP beta] Remove template-compiler.registerPlugin#19704
Merged
mixonic merged 1 commit intoemberjs:masterfrom Aug 22, 2021
nlfurniss:remove-template-compiler.registerPlugin
Merged
[CLEANUP beta] Remove template-compiler.registerPlugin#19704mixonic merged 1 commit intoemberjs:masterfrom nlfurniss:remove-template-compiler.registerPlugin
mixonic merged 1 commit intoemberjs:masterfrom
nlfurniss:remove-template-compiler.registerPlugin
Conversation
mixonic
previously requested changes
Aug 20, 2021
mixonic
previously requested changes
Aug 21, 2021
| @@ -80,110 +79,3 @@ interface LegacyPlugin { | |||
| } | |||
|
|
|||
| export type LegacyPluginClass = new (env: ASTPluginEnvironment) => LegacyPlugin; | |||
Member
There was a problem hiding this comment.
I think this can be removed now. There is a referencing in a typing file I'm not sure exactly how to unravel (seems to be entangled with a __raw property?) but do you think it can also be removed?
Contributor
Author
There was a problem hiding this comment.
I think it can be, but because I’m a TS noob I wasn’t sure how 😓
I took a stab at removing the interface. It is awkward (I left a comment in the code and pinged the #st-typescript channel on Discord) but I think satisfactory.
Member
|
Thank you @nlfurniss ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #19617
Deprecation site
Deprecation PR