Remove computed deep each#19673
Remove computed deep each#19673mixonic merged 1 commit intoemberjs:masterfrom nlfurniss:remove-computed-deep-each
Conversation
mixonic
left a comment
There was a problem hiding this comment.
@pzuraq This could use your eyes. I'm not sure which site should be changed to raise the error, and if the error should be a hard throw or simply a dev-only assert. As this code is performance sensitive, dev-only seems fine by my own intuition, but I'd like more feedback.
|
This should be a dev-only assert, definitely. I believe the location of the new error is correct though, it should catch both cases and properly prevent them (since the |
Sounds good, updated |
|
This looks great to me, I pushed a rebase of the branch to address a conflict and will merge. |
Part of #19662
ember-metal.computed-deep-eachTests pass locally
The code in
getChainTagswas deleted because it seems that that condition won't be reached since setting a deep dependent key will throw an error before it can begeted.