[CLEANUP] Remove Globals Resolver#19652
Conversation
5a0f14d to
f2649ac
Compare
|
@btecu there was a failure in the Node tests here, and this PR will require a rebase as well. |
|
@mixonic I might need some help with the Node tests failure if you have some time. |
|
@btecu the My commit adds a resolver to the app, thus avoiding the default resolver (which after your removal is just a hard failure). edit: I also rebased |
|
@mixonic thanks for the explanation and your help! |
| @property resolver | ||
| @public | ||
| */ | ||
| resolver: null, |
There was a problem hiding this comment.
This is weird. I see it was added in btecu@7b0a7ec#diff-a7583c2d819fdabaff78778f93e5112adc888bc3026338522862f08ddfadb4abR364 (or https://github.com/emberjs/ember.js/pull/12685/files#diff-a7583c2d819fdabaff78778f93e5112adc888bc3026338522862f08ddfadb4abR377 in the PR) by @dgeb but I don't see any usage of it. What am I missing? It was added with a @deprecated flag in jsdoc, but I don't see what is firing the deprecation.
There was a problem hiding this comment.
but I don't see what is firing the deprecation.
I wonder if the code firing the deprecation was removed prior to 3.0 without removing the deprecated prop? Regardless, it doesn't seem that the resolver class prop is referenced, so it seems safe to remove this now.
mixonic
left a comment
There was a problem hiding this comment.
Left an item I'd appreciate another set of eyes on. I think this is all good.
| @property resolver | ||
| @public | ||
| */ | ||
| resolver: null, |
There was a problem hiding this comment.
but I don't see what is firing the deprecation.
I wonder if the code firing the deprecation was removed prior to 3.0 without removing the deprecated prop? Regardless, it doesn't seem that the resolver class prop is referenced, so it seems safe to remove this now.
No description provided.