[CLEANUP beta] Remove deprecated mouse events#19650
Merged
mixonic merged 1 commit intoemberjs:masterfrom Aug 20, 2021
Merged
Conversation
Member
|
@btecu I believe there are some test failures in here still. |
Contributor
|
@btecu there are still tests failing here, and my recently merged changes related to the event dispatcher have caused merged conflicts here unfortunately. Do you still have time to work on this? Otherwise I could pick up your work here, and try to finish it. |
a92682d to
67599bf
Compare
Contributor
Author
|
@simonihmig I've rebased but yes, I'd appreciate the help with the failing test. |
Contributor
I don't have access to push to your branch, but after applying this diff all tests pass: diff --git a/packages/@ember/-internals/glimmer/tests/integration/components/fragment-components-test.js b/packages/@ember/-internals/glimmer/tests/integration/components/fragment-components-test.js
index ff692ad05..5d5fb77ae 100644
--- a/packages/@ember/-internals/glimmer/tests/integration/components/fragment-components-test.js
+++ b/packages/@ember/-internals/glimmer/tests/integration/components/fragment-components-test.js
@@ -67,7 +67,7 @@ moduleFor(
expectAssertion(() => {
this.render(`{{#foo-bar}}{{/foo-bar}}`);
- }, /You can not define `click,mouseEnter` function\(s\) to handle DOM event in the .* tagless component since it doesn't have any DOM element./);
+ }, /You can not define `click` function\(s\) to handle DOM event in the .* tagless component since it doesn't have any DOM element./);
}
['@test throws an error if a custom defined event function is defined in a tagless component']() { |
Contributor
|
All green now, awesome! 🎉 |
Contributor
Author
|
@nlfurniss thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @mixonic